m88rs6060: skip cold initialization when firmware is already running - #429
Open
smp79 wants to merge 1 commit into
Open
m88rs6060: skip cold initialization when firmware is already running#429smp79 wants to merge 1 commit into
smp79 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #410.
On a plain host reboot (no USB power cycle), m88rs6060_probe() unconditionally calls m88rs6060_ready(), which unconditionally:
Since the USB device is typically never actually power-cycled across a plain reboot, this runs against a demod chip that is still fully warm — firmware loaded. The result is intermittent misbehavior after the box comes back up: transponders lock, but with picture breakup / continuity-counter errors on some channels. A genuine power cycle is unaffected, since in that case the chip really is cold and needs this sequence.
If the chip is already warm (0xb9 non-zero), skip the hard reset, tuner/gain re-init, DiSEqC/FEC reset, and firmware reflash entirely — just reapply TS mode and return. If it's genuinely cold (0xb9 reads 0), fall through to the existing, unmodified cold-boot sequence.