This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Handle multiple submit buttons - #55
Open
agrath wants to merge 1 commit into
Open
Conversation
When using bs-confirmation with multiple input[type=submit] buttons, the current behaviour is to trigger form.submit after confirmation is received. If you have multiple submit buttons (with unique names/values) then this submits the form with the wrong action. This commit changes that behaviour so that if there are multiple submit buttons, the confirmation is destroyed then the click event reinvoked causing the original submit action to occur (which is browser submitting the form with the correct name/value specified for the clicked button)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using bs-confirmation with multiple input[type=submit] buttons, the current behaviour is to trigger form.submit after confirmation is received. If you have multiple submit buttons (with unique names/values) then this submits the form with the wrong action. This commit changes that behaviour so that if there are multiple submit buttons, the confirmation is destroyed then the click event reinvoked causing the original submit action to occur (which is browser submitting the form with the correct name/value specified for the clicked button)