fix: correct attach_yaml labels in MQTT request and response#1067
Open
reachsridhard wants to merge 1 commit into
Open
fix: correct attach_yaml labels in MQTT request and response#1067reachsridhard wants to merge 1 commit into
reachsridhard wants to merge 1 commit into
Conversation
Both MQTT request and response used 'rest_request'/'rest_response' as the attach_yaml name (copy-paste from REST plugin). This caused MQTT payloads to be incorrectly labeled as REST in test reports and allure attachments. - mqtt/request.py: 'rest_request' -> 'mqtt_request' - mqtt/response.py: 'rest_response' -> 'mqtt_response'
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughRenames the ChangesMQTT YAML Attachment Naming
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct attach_yaml labels in MQTT request and response
Summary
Both MQTT request and response used
rest_request/rest_responseas theattach_yamlname — a copy-paste error from the REST plugin. This caused MQTT payloads to be incorrectly labeled as REST in test reports and allure attachments.Changes
tavern/_plugins/mqtt/request.py:68name="rest_request"→name="mqtt_request"tavern/_plugins/mqtt/response.py:202name="rest_response"→name="mqtt_response"Testing
Summary by CodeRabbit