Repository navigation
fix(android): detect devices whose adb serial contains spaces - #531
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #522.
ADB_DEVICE_REGEXmatched the serial with[\S]{6,100}, so a line fromadb deviceswhose serial contains a space never matched. Devices paired over wireless debugging can have such serials, for exampleadb-7492209-mcwnUB (2)._adb-tls-connect._tcp, andcargo mobiledid not list them.adb devicesseparates the serial and the state with a tab, so the serial group now matches any characters except tab and newline. Every caller already passes the serial toadb -sas a separate argument, so serials with spaces work in later commands.Changes
src/android/adb/device_list.rs: match the serial with[^\t\n]{6,100}and add a test case for a wireless-debugging serial..changes/adb-serial-with-spaces.md: patch change file.Testing
cargo test --lib test_adb_output_regex: the new case fails ondev(left: []) and passes with the fix.cargo test: all tests pass.cargo fmt --check: clean.