Implement full touchscreen gameplay#525
Draft
trustytrojan wants to merge 3 commits into
Draft
Conversation
naoei
requested changes
Apr 5, 2025
naoei
left a comment
naoei
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution, however, I'm going to suspend this on the basis that none of this has been approved off and that there lacks user feedback on how mobile touch inputs should be handled in Tau.
Regardless, I've decided to review this code and give some insight into what our code style should look like.
Comment on lines
+38
to
+69
| Children = | ||
| [ | ||
| mainContent = new Container | ||
| { | ||
| RelativeSizeAxes = Axes.Both, | ||
| Alpha = 0, | ||
| Children = | ||
| [ | ||
| new Container | ||
| { | ||
| RelativeSizeAxes = Axes.Both, | ||
| Width = width, | ||
| Children = | ||
| [ | ||
| hardButton1 = new InputArea(TauAction.HardButton1, trackedActionSources) | ||
| { | ||
| RelativeSizeAxes = Axes.Both, | ||
| Height = normal_area_height_ratio, | ||
| Colour = colours.Gray9, | ||
| Anchor = Anchor.BottomRight, | ||
| Origin = Anchor.BottomRight, | ||
| }, | ||
| hardButton2 = new InputArea(TauAction.HardButton2, trackedActionSources) | ||
| { | ||
| RelativeSizeAxes = Axes.Both, | ||
| Height = 1 - normal_area_height_ratio, | ||
| }, | ||
| ] | ||
| }, | ||
| ], | ||
| }, | ||
| ]; |
Member
There was a problem hiding this comment.
All of this could be replaced with a simple GridContainer.
Contributor
Author
There was a problem hiding this comment.
Tried my best but I don't really know the osu-framework well enough to do this. Going to leave it as is because it works in its current state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just as the title says. Here's a video of my bad gameplay but with all inputs properly mapped to the Tau keybinds.
https://streamable.com/chio4f
Touch input overview
Please leave feedback or feel free to make commits to the branch. Would love to see this make a release. FYI this branch was created from the #524 branch, hopefully this shouldn't be a problem (considering it needs to actually work).