Vite Release#284
Merged
Merged
Conversation
This reverts commit b1c5b7c.
- Add botDetectionMiddleware that sets res.locals.is_bot and injects the value into the OTEL context via IS_BOT_KEY when tracing is enabled - Export IS_BOT_KEY from otel.js and read it in withObservability / withSyncObservability to stamp http.response.is_bot on all spans - Mount botDetectionMiddleware in expressServer before the catch-all handler Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
upgrades vite from 6.3.5 to 6.4.3 for resolving "CVE-2026-53571" and "CVE-2026-53632"
|
DeputyDev will no longer review pull requests automatically.To request a review, simply comment #review on your pull request—this will trigger an on-demand review whenever you need it. |
# Conflicts: # package-lock.json # packages/catalyst-core/package.json # packages/catalyst-core/src/server/renderer/handler.js # packages/catalyst-core/src/server/utils/userAgentUtil.js
# Conflicts: # .release-meta.json # apps/catalyst-core-test/package.json # apps/catalyst-core-test/server/server.js # apps/catalyst-core-test/src/js/pages/BreedDetails/BreedDetails.js # apps/catalyst-core-test/src/js/pages/Home/Home.js # package-lock.json # packages/catalyst-core/package.json # packages/catalyst-core/src/scripts/build.js # packages/catalyst-core/src/scripts/devBuild.js # packages/catalyst-core/src/scripts/loadEnvironmentVariables.js # packages/catalyst-core/src/scripts/start.js # packages/catalyst-core/src/server/expressServer.js # packages/catalyst-core/src/server/renderer/document/Body.jsx # packages/catalyst-core/src/server/renderer/document/Head.js # packages/catalyst-core/src/server/renderer/extract.js # packages/catalyst-core/src/server/renderer/handler.js # packages/catalyst-core/src/server/renderer/index.js # packages/catalyst-core/src/server/startServer.js # packages/catalyst-core/src/webpack/babel-plugins/remove-client.plugin.js # packages/catalyst-core/src/webpack/babel-plugins/remove-ssr.plugin.js # packages/catalyst-core/src/webpack/babel.config.client.js # packages/catalyst-core/src/webpack/babel.config.ssr.js # packages/catalyst-core/src/webpack/base.babel.js # packages/catalyst-core/src/webpack/development.client.babel.js # packages/catalyst-core/src/webpack/production.client.babel.js # packages/create-catalyst-app/templates/none-js/package.json # packages/create-catalyst-app/templates/none-ts/package.json # packages/create-catalyst-app/templates/redux-js/package.json # packages/create-catalyst-app/templates/redux-ts/package.json # packages/create-catalyst-app/templates/rtk-js/package.json # packages/create-catalyst-app/templates/rtk-ts/package.json # scripts/test-catalyst-core.sh
…@0.3.0-beta.1 [skip ci]
Uttkarsh-Srivastava
added a commit
that referenced
this pull request
Jul 22, 2026
renderToPipeableStream's pipe(res) in onShellReady and the handler's
own res.write()/res.end() in onAllReady were two independent
completion paths racing to close the same response. Whichever lost
was silently dropped (no error listener on res), truncating every
response: missing closing tags on react-dom 19.x, or lost deferred
asset scripts on 18.x, with Suspense fallbacks stuck permanently on
some documents.
Route React's output through a Transform ("tail") instead. React
auto-ends tail exactly like it auto-ended res before, but tail's
flush() hook is guaranteed to run once, appending the deferred asset
tags, before a plain tail.pipe(res) is allowed to end res. There is
now exactly one caller of res.end().
Rebased onto main post the Vite Release merge (#284), which replaced
the old webpack packages/catalyst-core/src/server/renderer/handler.js
with this handler.jsx (same defect, new location) and added safe-area
handling (cleanupSafeArea) that this fix preserves.
Fixes #320
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Migrates Catalyst Core’s web runtime from the old webpack/@tata1mg/router stack to a Vite-first SSR pipeline, with updated routing, split rendering, asset extraction, template support, and test coverage.
Core Runtime
require()compatibility.index.jsxand re-exports React Router plus Catalyst web-router helpers.preServerInitto preload app config/hooks before Express starts.SSR, Routing, And Data
RouterDataProvider,MetaTag, route data fetching, metadata merging, router context, and typed declarations.ClientRouterandServerRouterto use the new prepared route structure.req.originalUrl.Head,Body,render, andhandler.Vite Split And Asset Pipeline
split()andhydrationReady()as the Vite replacement for@loadable/component.SplitInviewfor visibility-gated loading and per-instance fallback support.split()calls.ssrTrue,ssrFalse,essential, and orphan chunks.serverFetcher,clientFetcher, andsetMetaDataremain available after lazy loading.PUBLIC_STATIC_ASSET_PATH/client/assets.Server Runtime
serve:inspect.Templates And Fixture App
catalyst-coreinstead of@tata1mg/router.@loadable/componentfrom templates and switches client hydration tohydrationReady().split()routes, native React Router index route shape, and Vite-compatible env reads.catalyst-corepackage metadata andbinduring test setup.Observability, Bots, And Security
OTEL_ENABLE.Build And Release
scripts/test-catalyst-core.shto replace builtdist,bin, and package metadata in the fixture before running checks.