fix(checkout): persist recomputed order total when payment method changes - #88
Merged
sampoyigi merged 2 commits intoAug 4, 2026
Conversation
…nges Selecting a new payment method only saved the payment code, so a stale pre-fee order_total (set earlier in the request) could be written to the database alongside it.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a checkout state persistence issue where changing the payment method could save the new payment code while leaving a stale (pre-fee) order_total on the persisted order, causing the stored order to not match the in-memory/cart-computed total.
Changes:
- Recompute
order_totalfrom the cart after applying the selected payment fee inCheckout::onChoosePayment(). - Persist both
paymentandorder_totaltogether whenever either value differs from what’s currently stored on the order.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Avoids computing the cart total twice and guarantees the comparison and the persisted value are the same total.
sampoyigi
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When switching payment methods during checkout, only the payment code was saved to the order. The
order_totalattribute in memory had already been computed before the fee was applied for the request, soupdateQuietly()could persist a stale, pre-fee total alongside the new payment code.Companion fix to tastyigniter/ti-ext-cart#138, which addresses why the fee wasn't applying in the first place.
Fix
Checkout::onChoosePayment()now recomputes and savesorder_totalfrom the cart alongsidepaymentwhenever either has changed, so the persisted order always matches the currently selected payment method.