Refactor chatbase to use the new chat completion method in ChatCraftChat class. - #832
Open
aldrin312 wants to merge 10 commits into
Open
Refactor chatbase to use the new chat completion method in ChatCraftChat class.#832aldrin312 wants to merge 10 commits into
aldrin312 wants to merge 10 commits into
Conversation
Deploying chatcraft-org with
|
| Latest commit: |
f55f156
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f6e3419b.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://refactorchatbase.console-overthinker-dev.pages.dev |
cleanup
Collaborator
Author
|
Create a new hook for chat completion. I find it doing it like this is much more easier and cleaner. I'm not sure if the completion method in the ChatCraftChat class should be removed now. |
Collaborator
|
You don't want to limit the ability to do chat completions to React Components, which a hook-only approach would do. We should have both ways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new method for chat completion the ChatCraftChat class and refactored ChatCraftBase to use the new method.
The new method doesn't implement UI elements like forceScrolling. May need to refactor again to include it.
Currently all of the hooks are being passed in from ChatCraftBase. Wasn't sure how to use them directly in ChatCraftChat class or if they are possible to use.
Issues: #819 and #820