Add Union type hints to full_grid_input_partial#3
Open
richardmcmillen wants to merge 1 commit into
Open
Conversation
This method is called either with a number or a string, and without the `int` type hint there is an error in the logs. ``` 2022-04-14 16:26:24 ERROR TalonScript TypeError in: /Users/rickymcmillen/.talon/user/dense-mouse-grid/dense_mouse_grid/full_mouse_grid_open.talon:19 2022-04-14 16:26:24 ERROR Line 20: user.full_grid_input_partial(letter: str) 2022-04-14 16:26:24 ERROR Line 20: parameter 1 (letter) expects type <class 'str'>, got <class 'int'> ``` This did not appear to effect the functionality at all.
Author
|
I tried declaring this as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is called either with a number or a string, and without the
inttype hint there is an error in the logs.This did not appear to effect the functionality at all.
(I have no idea how to python, I learnt this from a quick google)