Skip to content

feat: enhance useSyncConnection to streamline connection updates and … #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feynmx merged 1 commit into from
Jun 16, 2026
Merged

feat: enhance useSyncConnection to streamline connection updates and … #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 13 additions & 34 deletions packages/dag/src/composables/useFormScope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -865,7 +865,7 @@ export function useFormScope({ canvasRef }) {

findParentNodeByType,

useSyncConnection: async (field) => {
useSyncConnection: async (field: any) => {
const id = field.value
const form = field.form
const connection = await getConnectionNoSchema(id)
Expand All @@ -875,39 +875,18 @@ export function useFormScope({ canvasRef }) {
return
}

const connectionType = form.getValuesIn('attrs.connectionType') || ''
const accessNodeProcessId =
form.getValuesIn('attrs.accessNodeProcessId') || ''
const accessNodeType = form.getValuesIn('attrs.accessNodeType') || ''
const priorityProcessId =
form.getValuesIn('attrs.priorityProcessId') || ''
const connectionName = form.getValuesIn('attrs.connectionName')
const pdkType = form.getValuesIn('attrs.pdkType')
const pdkHash = form.getValuesIn('attrs.pdkHash')
const db_version = form.getValuesIn('attrs.db_version')

pdkType !== connection.pdkType &&
form.setValuesIn('attrs.pdkType', connection.pdkType)
pdkHash !== connection.pdkHash &&
form.setValuesIn('attrs.pdkHash', connection.pdkHash)
connectionType !== connection.connection_type &&
form.setValuesIn('attrs.connectionType', connection.connection_type)
accessNodeProcessId !== connection.accessNodeProcessId &&
form.setValuesIn(
'attrs.accessNodeProcessId',
connection.accessNodeProcessId,
)
accessNodeType !== connection.accessNodeType &&
form.setValuesIn('attrs.accessNodeType', connection.accessNodeType)
priorityProcessId !== connection.priorityProcessId &&
form.setValuesIn(
'attrs.priorityProcessId',
connection.priorityProcessId,
)
connectionName !== connection.name &&
form.setValuesIn('attrs.connectionName', connection.name)
db_version !== connection.db_version &&
form.setValuesIn('attrs.db_version', connection.db_version)
form.setFieldState('connectionConfig', { data: connection.config })
form.setValuesIn('attrs.pdkType', connection.pdkType)
form.setValuesIn('attrs.pdkHash', connection.pdkHash)
form.setValuesIn('attrs.connectionType', connection.connection_type)
form.setValuesIn(
'attrs.accessNodeProcessId',
connection.accessNodeProcessId,
)
form.setValuesIn('attrs.accessNodeType', connection.accessNodeType)
form.setValuesIn('attrs.priorityProcessId', connection.priorityProcessId)
form.setValuesIn('attrs.connectionName', connection.name)
form.setValuesIn('attrs.db_version', connection.db_version)
},

getPdkProperties: (node) => {
Expand Down
4 changes: 3 additions & 1 deletion packages/dag/src/nodes/Database.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ export class Database extends NodeType {
'x-display': 'hidden',
'x-reactions': '{{useSyncConnection}}',
},

connectionConfig: {
type: 'void',
},
type: {
type: 'string',
'x-display': 'hidden',
Expand Down
3 changes: 3 additions & 0 deletions packages/dag/src/nodes/Table.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ export class Table extends NodeType {
'x-reactions':
'{{useAsyncDataSourceByConfig({service: useSyncConnection})}}',
},
connectionConfig: {
type: 'void',
},
tabs: {
type: 'void',
'x-decorator': 'FormItem',
Expand Down
Loading