Skip to content

Tap 12434 v2.0.8 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarad0628 merged 2 commits into from
Aug 24, 2026
Merged

Tap 12434 v2.0.8 #861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
669bd55
feat: TAP-12434 add sheet name into context info
mnianqi Aug 21, 2026
848fcdb
feat: TAP-12434 remove log info
mnianqi Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion connectors/excel-connector/src/main/java/io/tapdata/connector/excel/ExcelConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ protected void readOneFile(FileOffset fileOffset, TapTable tapTable, int eventBa
List<Integer> sheets = sheetNumbers.stream().filter(n -> n >= fileOffset.getSheetNum()).collect(Collectors.toList());
for (int i = 0; isAlive() && i < sheets.size(); i++) {
Sheet sheet = wb.getSheetAt(sheets.get(i) - 1);
String sheetName = sheet.getSheetName();
List<CellRangeAddress> mergedList = sheet.getMergedRegions();
int lastMergedRow = mergedList.stream().map(CellRangeAddressBase::getLastRow).max(Comparator.naturalOrder()).orElse(-1);
Map<CellRangeAddress, Cell> mergedDataMap = ExcelUtil.getMergedDataMap(sheet);
Expand Down Expand Up @@ -112,6 +113,7 @@ protected void readOneFile(FileOffset fileOffset, TapTable tapTable, int eventBa
recordEvent.addInfo("lastModified", lastModified);
recordEvent.addInfo("filePath", fileOffset.getPath());
recordEvent.addInfo("fileName", fileOffset.getPath().substring(fileOffset.getPath().lastIndexOf("/") + 1));
recordEvent.addInfo("sheetName", sheetName);
tapEvents.get().add(recordEvent);
if (tapEvents.get().size() == eventBatchSize) {
fileOffset.setDataLine(fileOffset.getDataLine() + eventBatchSize);
Expand All @@ -137,7 +139,7 @@ private void checkCellType(Integer col, Cell cell, Map<Integer, CellType> cellTy
}
CellType cellType = cellTypeMap.get(col);
if (checkLevel(cellType) != checkLevel(cell.getCellType())) {
tapLogger.info(String.format("The data type of line %s, column %s is inconsistent, please check the data in the excel file", cell.getRowIndex() + 1, col + 1));
// tapLogger.info(String.format("The data type of line %s, column %s is inconsistent, please check the data in the excel file", cell.getRowIndex() + 1, col + 1));
}
}

Expand Down