docs(clickhouse): add Int64 and Array to supported data types - #232
Open
heywalter wants to merge 1 commit into
Open
docs(clickhouse): add Int64 and Array to supported data types#232heywalter wants to merge 1 commit into
heywalter wants to merge 1 commit into
Conversation
Both types are declared in the connector spec but missing from the table. Insertion positions follow the spec's own declaration order: Int64 sits between UInt32 and UInt64, matching the table's existing ordering. Array carries queryOnly: true in the spec. No boundary note is added here: 7 of the 8 queryOnly types in this table (including Tuple, on the same row) are already listed without any note, so annotating only Array would imply a distinction that does not exist in the code. Evidence: connectors/clickhouse-connector/src/main/resources/spec_clickhouse.json:579 Int64 connectors/clickhouse-connector/src/main/resources/spec_clickhouse.json:729 Array tapdata-connectors @ 76fbafd39a2739ab847eb12fb0c38511eade112f DocsLoop-Task: T-1
heywalter
added
the
docs-loop
✅ Deploy Preview for tapdata-en ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add two data types to the ClickHouse Supported Data Types table:
Both types are declared in the connector spec but were missing from the doc table.
Why here / why this order
Insertion positions are not chosen by hand — they follow the spec's own declaration order:
Int64sits betweenUInt32andUInt64in the spec, which matches the table's existing ordering.Evidence
Every claim below is pinned to a commit sha, so these links keep pointing at the
exact lines that were read — even after
mainmoves on.Int64[($zerofill)]Array($type)tapdata-connectors @
76fbafdOne deliberate omission
ArraycarriesqueryOnly: truein the spec. No boundary note is added, on purpose:queryOnlytypes already in this table (includingTuple, on the same row) are listed without any note — annotating onlyArraywould imply a distinction that does not exist in the code.queryOnlyhas no consumer in the connector repos (it appears only in spec.json), so its exact semantics can't be derived from code here.queryOnlytypes are not described as target-unsupported; the real unsupported list there is drawn by CDC plugin, not byqueryOnly.If a "type boundary annotation" editorial standard is wanted, it affects ~45 connectors and needs the engine-side semantics of
queryOnlyfirst — that's a separate initiative, not this PR.Validation
origin/main(baseline already carries 83 pre-existing warnings; absolute count is not a gate — the delta is).🤖 Proposed by Docs Loop ·
DocsLoop-Task: T-1Every claim above traces to
file:line@sha. Reply on any line if a call is wrong — we tighten the rule, not just this PR.