Support JWTs 1.0 (keep 0.3 compatibility) - #29
Merged
Conversation
JWTs 1.0 intentionally exports no names (they are declared `public` instead of exported), so the previous `using JWTs` no longer brings `JWKSet`, `JWT`, `JWK`, `issigned`, `claims`, `refresh!`, `validate!` into scope. Switch to a selective `using JWTs: ...` import, which resolves the bindings directly and works unchanged on both 0.3 and 1.0. All of the names used here exist with compatible signatures in both versions, so no logic changes are required. Widen the JWTs compat bound to include 1 and bump the patch version to 0.2.1. Test suite passes against both JWTs 0.3.2 and 1.0.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
krynju
marked this pull request as ready for review
July 1, 2026 08:59
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
==========================================
- Coverage 50.45% 45.86% -4.60%
==========================================
Files 1 1
Lines 109 133 +24
==========================================
+ Hits 55 61 +6
- Misses 54 72 +18 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds support for JWTs 1.0 while keeping backward compatibility with 0.3.
Why
JWTs 1.0 intentionally exports no names — the public API is declared with
publicinstead ofexport. As a result,using JWTsno longer bringsJWKSet,JWT,JWK,issigned,claims,refresh!,validate!into scope, and OpenIDConnect fails to load against JWTs 1.0.Change
using JWTswith a selectiveusing JWTs: JWKSet, JWT, JWK, issigned, claims, refresh!, validate!. A selective import resolves the bindings directly regardless of export/public status, so it works unchanged on both 0.3 and 1.0.[compat]JWTs to"0.1, 0.2, 0.3, 1".0.2.0→0.2.1.Testing
Full test suite passes against both JWTs 0.3.2 and 1.0.0 (34/34).
🤖 Generated with Claude Code