This repository was archived by the owner on Aug 8, 2026. It is now read-only.
fix: exit 0 when there is nothing to release - #1705
Merged
Merged
Conversation
The weekly release workflow was failing with a stack trace whenever no PRs had merged since the last tag, which is a normal outcome, not an error. release() now resolves 'nothing-to-release' instead of throwing, so the CLI prints a message and exits 0 in that case while still failing loudly for genuine validation errors (unlabelled or multi-labelled PRs). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Releaseworkflow was failing (red X, notification noise) whenever no PRs had merged since the last tag -release()threwError('Nothing to release'), whichcli.tstreated the same as any other command failure (console.error+process.exit(1)).release()now resolves'nothing-to-release'in that case instead of throwing;cli.tsprintsNothing to releaseand exits 0. Genuine validation errors (unlabelled PRs, PRs with multiple labels) are unchanged and still exit 1.Test plan
npm run check:types,npm run lint,npm run check:formatall passnpm run buildsucceedsnpm run test:srcandnpm run test:cjsboth pass all 3releaseunit tests (source and compileddistbehave identically)cli.test.tsfailures (authors/changelog integration tests needing a liveCHANGELOG_GITHUB_TOKEN) are pre-existing onmaster, not introduced by this change🤖 Generated with Claude Code