Skip to content

Add shared const opcode definitions#315

Merged
guosran merged 1 commit into
tancheng:masterfrom
guosran:fix/shared-const-opcodes
Jun 26, 2026
Merged

Add shared const opcode definitions#315
guosran merged 1 commit into
tancheng:masterfrom
guosran:fix/shared-const-opcodes

Conversation

@guosran

@guosran guosran commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

This PR only adds the shared opcode definitions needed by the const-op RTL fixes. It intentionally does not change any RTL module behavior.

The following module-specific PRs depend on these opcode names:

  • DivRTL REM_CONST
  • CompRTL const comparisons
  • GrantRTL grant_once const
  • ShifterRTL const shifts
  • ConstQueueDynamicRTL const-op consume tracking
  • conv small validation config generation

Validation:
This branch is metadata-only. I also verified that merging this shared branch before the other split branches avoids duplicated lib/opt_type.py diffs.

@guosran

guosran commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Concrete example:
Before this shared PR, each const-op PR had to repeat the same lib/opt_type.py diff.

After this PR:

shared opcode PR
|
+-- #299 DivRTL uses OPT_REM_CONST
+-- #305 CompRTL uses const comparison opcodes
+-- GrantRTL uses OPT_GRT_ONCE_CONST
+-- ShifterRTL uses OPT_LLS_CONST
+-- ConstQueueDynamicRTL tracks const-op consumption

This keeps RTL PRs focused on one module each.

@tancheng tancheng requested review from BenkangPeng and yyan7223 June 26, 2026 18:12
@guosran guosran merged commit 88348b3 into tancheng:master Jun 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants