Skip to content

Hold tile control until datapath completion#313

Open
guosran wants to merge 1 commit into
tancheng:masterfrom
guosran:fix/tile-control-completion-rtl
Open

Hold tile control until datapath completion#313
guosran wants to merge 1 commit into
tancheng:masterfrom
guosran:fix/tile-control-completion-rtl

Conversation

@guosran

@guosran guosran commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses #292 with a minimized tile control-completion fix. This PR only updates TileRTL.py.

Changes

  • Keep FU control valid until both the FU and FU crossbar have completed.
  • Let crossbars observe same-cycle FU completion.
  • Avoid advancing tile control before all datapath consumers finish.

Validation

Part of the master-based small conv passing set.

@guosran guosran force-pushed the fix/tile-control-completion-rtl branch 3 times, most recently from 40daaf5 to c71dbfd Compare June 25, 2026 20:02
@guosran guosran marked this pull request as draft June 25, 2026 20:05
@guosran guosran force-pushed the fix/tile-control-completion-rtl branch 4 times, most recently from 792de6c to d111883 Compare June 26, 2026 00:14
@guosran guosran force-pushed the fix/tile-control-completion-rtl branch from d111883 to 1d89097 Compare June 26, 2026 00:16
@guosran guosran marked this pull request as ready for review June 26, 2026 00:42
@guosran

guosran commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Tile control should not advance just because the FU element is done if the FU crossbar still has to consume the output.

cycle N:
element_done = 1
fu_crossbar_done = 0

Before:
ctrl could advance and the FU output could be dropped.

After:
TileRTL keeps the current control active until the relevant datapath/crossbar completion is observed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant