Skip to content

Retire pending const queue consumes#312

Open
guosran wants to merge 2 commits into
tancheng:masterfrom
guosran:fix/const-queue-pending-consume-rtl
Open

Retire pending const queue consumes#312
guosran wants to merge 2 commits into
tancheng:masterfrom
guosran:fix/const-queue-pending-consume-rtl

Conversation

@guosran

@guosran guosran commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses #292 with a minimized const queue consume fix. This PR updates ConstQueueDynamicRTL.py plus shared opcode definitions in lib/opt_type.py.

Changes

  • Remember a const consume handshake until ctrl_proceed retires it.
  • Prevent const queue read pointer updates from being lost when consume and control proceed happen in different cycles.
  • Add the required shared const opcode list.

Validation

Part of the master-based small conv passing set.

@guosran guosran force-pushed the fix/const-queue-pending-consume-rtl branch from 2d45314 to 555104b Compare June 25, 2026 19:46
@guosran guosran marked this pull request as draft June 25, 2026 20:05
@guosran guosran marked this pull request as ready for review June 26, 2026 00:42
@guosran

guosran commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator Author

Some const operations consume a const token later than the opt token arrives.

cycle 0: opt arrives for ADD_CONST
cycle 1: const token arrives

Before:
const queue could treat the opt as already handled and lose alignment.

After:
ConstQueueDynamicRTL tracks pending const consumption until the const token is actually accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant