Allow zero identity add predicate#308
Open
guosran wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Adder output should not become active only because payload is zero/nonzero; predicate must control activity. input payload = 0 Expected: |
tancheng
reviewed
Jun 26, 2026
| if s.recv_in[s.in0_idx].msg.predicate & s.recv_in[s.in1_idx].msg.predicate: | ||
| s.send_out[0].msg.predicate @= s.reached_vector_factor | ||
| elif s.recv_in[s.in0_idx].msg.predicate & \ | ||
| ~s.recv_in[s.in1_idx].msg.predicate & \ |
Owner
There was a problem hiding this comment.
Why s.recv_in[s.in1_idx].msg.predicate won't affect output's predicate?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #292 with a minimized Adder predicate fix. This PR only updates
AdderRTL.pyand its focused test.Changes
Validation