Repository navigation
Conversation
tamnd
added
priority/p0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The job "minimum supported Rust version" fails on main. Four match arms use
if letguards, the first one since #370, and Rust 1.88, the lowest version inrust-version, does not have them. This change writes the four arms without the guards. The behavior does not change.Changes
mark_originsin rupg-analyze matches the subquery and the data-modifying CTE of the relation together.flatten_grouping_setsin rupg-analyze look for an implicit row in the last arm.apply_writein rupg-session matches the write kind and theON CONFLICTarbiters together.Known differences
None.
Tests
cargo +1.88.0 check --workspace --all-featurespasses.cargo test -p rupg-analyze -p rupg-sessionpasses on Linux. On macOSfloat_mathandgeofn2fail as before, see Q20 (Q20: Do math functions give the same answers on other platforms? #33) and Make the nightly jobs pass again #455.