Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3.
rupg now makes the last two functions of
information_schema.sql:_pg_expandarrayand_pg_index_position. Before this change, the setup skipped them, becauseCREATE FUNCTIONtook only aRETURNbody. The views ofinformation_schemacall these two functions, so this is a step to the views._pg_expandarrayhas a query in a string,SETOF record, polymorphicOUTparameters,ROWSandSUPPORT._pg_index_positionhas a query inBEGIN ATOMIC. The analyzer reads the body again for each call with the actual types of the arguments, so a polymorphic argument has its actual type in the query.What changes
CREATE FUNCTIONtakesOUT,INOUTandTABLEparameters,SETOF,ROWS,SUPPORT, a body in a string and a body inBEGIN ATOMIC. The result type comes from theOUTparameters as inCreateFunction.check_sql_fn_retval: the number of columns and an assignment cast of each column to the type of the result column.proretset,prosupport,proallargtypes,proargmodesandprosrc, andpg_procshows them.Test
sql_bodies. Its expected output is the output of PostgreSQL 19 for the same script in a new database. It calls the functions inFROM, in the target list and withLATERAL, with null, empty, two dimension andint2vectorarguments. It also reads the rows ofpg_procandpg_dependand the output ofpg_get_function_argumentsandpg_get_function_result.