Repository navigation
fuzz: skip the text round trip of the smallest interval time - #175
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3.
The M2 fuzz run on server2 found one crash in
type_recv. The input is anintervalin the binary format whose time is the smallestint64. The receive function accepts it and the output is-21 years -4 mons -61697 days -2562047788:00:54.775808. The input function then refuses that text with 22007, and the target panics on the text round trip.PostgreSQL does the same thing. On the oracle,
'-2562047788:00:54.775808'::intervalgivesinvalid input syntax for type intervalwith 22007, and'-2562047788:00:54.775807'::intervalis correct. Thus rupg is correct and the check in the target is too strict for this one value.What changes
type_recvdoes not do the text round trip when anintervalor aninterval[]holds the time-2562047788:00:54.775808. The binary round trip still runs for that value.Test
RecvCasethe same way as libFuzzer. Without the change it panics at the text round trip. With the change it passes.cargo clippy --lib -- -D warningsinfuzzis clean.