Repository navigation
Repair the fuzz session after the Session trait change - #164
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #163 changed the
Sessiontrait ofrupg-func:zonenow gives anRc<dyn TimeZone>, and the new methodset_settingchanges a setting. The fuzz crate is a separate workspace, and the main test run does not build it. Thus the fuzz session infuzz/src/types.rsdid not compile after #163, and the nightly fuzz job would fail.What changes:
FuzzSessionkeeps its zone in anRcand gives a clone of it fromzone.FuzzSession::set_settinggives an internal error, as the test sessions do. No fuzz target callsset_config.How I tested it:
cargo check --all-targetsandcargo fmt --checkinfuzz/pass on the stable toolchain, andcargo +nightly fuzz build -Obuildswire_frontend,wire_startup,type_inputandtype_recvon server1. From now on, my test run before a merge also checks the fuzz workspace.