Repository navigation
Conversation
5 of 17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1.
What changes
src/pg.rsis a small client for protocol 3.0 of PostgreSQL. It uses no crate and connects over a Unix socket or TCP. It supports trust and cleartext password authentication, and the simple query protocol. spec/20 §20.9 nameslibpq. The harness has no dependencies, so it uses this client.src/pgbench.rsreads the summary that pgbench prints and holds the consistency check of spec/21 §21.4.6. The check needs sum(abalance) = sum(tbalance) = sum(bbalance). The row count ofpgbench_historymust also equal the transaction count that pgbench printed.rupg-bench pgbench (--unit U | --attach P)does these steps:pgbench -i -q -s N.pgbench -c -j -Tand measure the server cgroup over the run.A failed check makes the command fail with "wrong answer".
--smokemarks the result as a smoke run.--report DIRwrites the report files, and a failed run also gets them, with its error.cgroup.rs: whenio.statis missing, the io bytes are nownullwith the text "not measured". They were 0 before. The first real run showed this: systemd does not turn on the io controller for a unit withoutIOAccounting=yes, soio.statwas missing and the result showed 0 bytes written.machines/install/postgresql.shnow does three more things:CPUAccounting,MemoryAccountingandIOAccountingforpostgresql@19-mainonly.bench(LOGIN, withpg_read_server_files) and the databasebench.local all bench trustas the first rule ofpg_hba.conf.RUPG_BENCH_COMMITsets the harness commit for a copy of the tree that has no.git.reports/2026-10-07/de0a7ce2-server3-pgbench-smoke.mdand.jsonare the report of the smoke run below. Their names and their first line mark them as a smoke run.Test
srvtestpassed on server3: clippy is clean and 40 tests pass.shellcheck -xis clean on the install script.PostgreSQL REL_19_STABLE at
7d3d2db7was built from source on server3 withmachines/install/postgresql.sh. It reportsPostgreSQL 19beta4 on x86_64-pc-linux-gnu, compiled by gcc (Ubuntu 13.3.0-6ubuntu2~24.04.1) 13.3.0, 64-bit.Smoke run on server3, 7 October 2026, 09:03:45 to 09:04:34 UTC. This is not a baseline. server3 is a shared machine with 8 cores, and its load average was 77 to 84 during the run.
The sampler took 44 samples in 31 s, against 310 at 100 ms. The load of the machine causes the gap, and the result records the count. A run before the io fix also passed its check, with 731 transactions in 30 s.