Repository navigation
Read a string literal in an aggregate call as PostgreSQL resolves it - #3030
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2492.
PostgreSQL resolves a string literal in an aggregate call through the usual function lookup. The literal has the unknown type, and the aggregate candidates decide which type it gets. So
avg('4')has two equal candidates and fails with 42725, andmax('x')reads the literal as text.The first part of this work landed in #3002 by accident, because a commit chain picked up the edit. That part resolves the unknown arguments of a plain aggregate call. This PR finishes the work:
sum('x') over ()fails with 42725 as in PostgreSQL.f64::mindrops NaN. It now clamps only a real value above 1, so a NaN input gives NaN as in PostgreSQL.The harness goes from 1869 to 1873 statements that are the same on rudb, with no new differences.