Skip to content

Hold extract to the catalog call in the transform test, not to the DuckDB tree - #3000

Merged
tamnd merged 1 commit into
mainfrom
fix-release-tests
Oct 10, 2026
Merged

tamnd merged 1 commit into
mainfrom
fix-release-tests

Conversation

@tamnd

@tamnd tamnd commented Oct 10, 2026

Copy link
Copy Markdown
Owner

#2968 made the PostgreSQL transform read extract(field from x) as pg_catalog.extract('field', x), the way PostgreSQL 14 and later do. The DuckDB transform still reads it as date_part('FIELD', x), and the test that holds the two transforms to the same tree had an extract in its list, so cargo test -p rudb-pgparse --test transform has failed since. The release gate stops on it, which is one of the two tests that kept 0.10.7 off crates.io.

The statement in the list keeps everything but the extract, and a test of its own checks that the new transform makes the catalog call with the field in lower case. The rest of that statement was compared against the failing output on server3 and builds the same tree in both.

@tamnd tamnd added kind/test Test apparatus rather than the thing tested. area/build The workspace, CI, release, the layer rule. labels Oct 10, 2026
@tamnd
tamnd merged commit 09c9a24 into main Oct 10, 2026
1 check failed
@tamnd
tamnd deleted the fix-release-tests branch October 10, 2026 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build The workspace, CI, release, the layer rule. kind/test Test apparatus rather than the thing tested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant