Repository navigation
Hold extract to the catalog call in the transform test, not to the DuckDB tree - #3000
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2968 made the PostgreSQL transform read
extract(field from x)aspg_catalog.extract('field', x), the way PostgreSQL 14 and later do. The DuckDB transform still reads it asdate_part('FIELD', x), and the test that holds the two transforms to the same tree had anextractin its list, socargo test -p rudb-pgparse --test transformhas failed since. The release gate stops on it, which is one of the two tests that kept 0.10.7 off crates.io.The statement in the list keeps everything but the
extract, and a test of its own checks that the new transform makes the catalog call with the field in lower case. The rest of that statement was compared against the failing output on server3 and builds the same tree in both.