Repository navigation
job-gate: run a query again when its q-error document does not parse - #282
Merged
Merged
Conversation
tamnd
added
kind/test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of J8 (tamnd/rudb#1852).
The first full
qerror norulerun on server2 stopped at 6d, because DuckDB's JSON profile for that query did not parse. Run on its own a minute later the same query gave a whole profile, so the file was cut short. The disk on server2 is 99% full and shared, which is the likely cause.gradednow runs a query up to three times when the document it reads back does not parse, and givesNoneafter that, which the loop already writes as an error row. Before this, one bad document ended the run and lost the summary for every query.