Repository navigation
kv: add --mode index, the W4 gate of a keyed load against the same load without the key - #281
Merged
Merged
Conversation
…ad without the key
13 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of tamnd/rudb#1387 (W4), the index gate of
17-milestones.md: building the key of a load of 10 million rows adds at most a tenth to the same load without it.--mode indexloads--recordsrows of(id BIGINT, v BIGINT)into a fresh table without a key and into one withidas its primary key,--runstimes each, and drops both after each load. The two take turns, and which one goes first alternates by run, so neither always meets a file that just grew. The gate is judged on the medians. It runs on rudb, DuckDB and PostgreSQL, each loading from its own row generator.On server3 with rudb and the W4 key work, 10 million rows over 5 runs: a median of 3.361 s without the key and 3.425 s with it, 1.9% added, a pass. The box was under a load of about 80 from other jobs, so single runs swing by tens of percent either way and only the medians mean much.
Tests: the median of an odd and an even count, and of nothing.