Skip to content

kv: add --visibility committed, rudb showing a commit before it is durable, for the freshness runs - #280

Merged
tamnd merged 1 commit into
mainfrom
ch-visibility
Oct 9, 2026
Merged

tamnd merged 1 commit into
mainfrom
ch-visibility

Conversation

@tamnd

@tamnd tamnd commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Part of tamnd/rudb#1390 (W7), the freshness measure under visibility = committed and visibility = durable.

The freshness line of the CH-benCHmark runs only ever measured rudb at its default, durable, since the driver never set visibility. W7 asks for both.

  • --visibility durable|committed, durable unless set. Under committed rudb shows a commit's rows to other sessions once the commit is ordered, before it is durable.
  • The Backend trait gets visibility. rudb runs SET visibility = '...' right after commit_sync, and the shim passes it through. Every other engine shows a commit once it is durable, so it takes durable and refuses committed with a sentence saying so, the way level refuses a level an engine cannot set.
  • The tpcc header line carries visibility= after isolation=.

Tests

The argument test takes both words and refuses a third.

@tamnd tamnd added kind/feature It should do something it does not. area/tpc TPC-H and TPC-DS. labels Oct 9, 2026
@tamnd
tamnd merged commit bad6e63 into main Oct 9, 2026
1 check failed
@tamnd
tamnd deleted the ch-visibility branch October 9, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/tpc TPC-H and TPC-DS. kind/feature It should do something it does not.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant