Repository navigation
kv: add --visibility committed, rudb showing a commit before it is durable, for the freshness runs - #280
Merged
Conversation
…rable, for the freshness runs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of tamnd/rudb#1390 (W7), the freshness measure under
visibility = committedandvisibility = durable.The freshness line of the CH-benCHmark runs only ever measured rudb at its default,
durable, since the driver never setvisibility. W7 asks for both.--visibility durable|committed,durableunless set. Undercommittedrudb shows a commit's rows to other sessions once the commit is ordered, before it is durable.Backendtrait getsvisibility. rudb runsSET visibility = '...'right aftercommit_sync, and the shim passes it through. Every other engine shows a commit once it is durable, so it takesdurableand refusescommittedwith a sentence saying so, the waylevelrefuses a level an engine cannot set.tpccheader line carriesvisibility=afterisolation=.Tests
The argument test takes both words and refuses a third.