Add kit domain layer for 36Kr#1
Open
tamnd wants to merge 1 commit into
Open
Conversation
Wires the existing kr36 package into the any-cli/kit framework so the binary and a multi-domain host share one source of truth: - domain.go: Domain struct, Register (article resolver + news list op), newClient factory, Classify/Locate URI helpers - domain_test.go: offline tests for DomainInfo, Classify, Locate, host wiring (Mint + ResolveOn round-trip) - types.go: add ID field and kit/table struct tags to Article - kr36.go: add Host constant, populate Article.ID from URL, strip feed-tracking query params from the URL field - go.mod/go.sum: add github.com/tamnd/any-cli v0.2.0 All 9 tests pass (5 existing + 4 new domain tests).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kr36package into theany-cli/kitframeworkdomain.gowithDomainstruct,Register(article resolver + news list op),newClientfactory, andClassify/LocateURI helpersdomain_test.gowith offline tests forDomainInfo,Classify,Locate, and host wiring (Mint + ResolveOn round-trip)types.goto addIDfield andkit/tablestruct tags toArticlekr36.goto addHostconstant, populateArticle.IDfrom the URL, and strip feed-tracking query params from theURLfieldgithub.com/tamnd/any-cli v0.2.0dependencyTest plan
go test ./kr36/...go build ./...kr36 newslists articles from the RSS feed