Add support for POSIX shell plugin#25
Merged
Merged
Conversation
taminob
changed the title
taminob
force-pushed
the
feature/add-posix-shell-plugin
branch
from
9373a7b to
650f4d5
Compare
taminob
force-pushed
the
feature/add-posix-shell-plugin
branch
from
650f4d5 to
4f2a153
Compare
…runtime error workaround
This project will prefer the STL algorithms over the boost helpers.
Additionally, add a TODO for PythonPlugin and LuaPlugin for the bool conversion because it returns a static true. If a function exits the interpreter, the plugin can stop before the destruction of the plugin.
taminob
force-pushed
the
feature/add-posix-shell-plugin
branch
from
9c506fc to
aff255b
Compare
… non-const if necessary
By avoiding exceptions, the interface became clunky and hard to use. Instead, it is now the responsibility of the user to avoid exceptions by doing proper checking before calling these functions. The old interface remains a part of the Expected class for now in the form of valueOptional()/errorOptional() and valueOptionalRef()/errorOptionalRef().
taminob
force-pushed
the
feature/add-posix-shell-plugin
branch
from
60b1465 to
8504909
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support for POSIX shell plugins.
For this, it creates a subprocess containing a shell.
The functions are called by entering them via stdin in the interactive shell.
In order to detect the end of the process, a random end marker is written to stdout that marks the end of stdout of the function.
The entire stdout of the function is interpreted as its result. If the function exits with an exit code not equal to zero, a
CallErroris returned instead of stdout.Additionally, some improvements and fixes were applied to
GenericPluginandExpected.Resolves #18