Recording-safety bundle: disabled!=idle (#1059), preserve leftover recordings (#1249), NodeId health key (#1078) - #2
Open
Harishkrishna17 wants to merge 3 commits into
Open
Conversation
(cherry picked from commit d003910)
The entrypoint wipes /home/egress/tmp on every start. If a container restarted mid-egress (crash, OOM, redeploy), any in-progress recording in tmp was lost before it could be recovered. Copy a non-empty tmp into /home/egress/recovered before the cleanup, so operators can retrieve partial output from the previous session. The copy is skipped when tmp is empty, leaving normal startup unchanged. (cherry picked from commit e1e9bd2)
(cherry picked from commit a89f423)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports three small, independent upstream recording-safety / correctness fixes into the Talview fork.
Included (cherry-picked,
-xtrailer preserved)IsIdle() && !IsDisabled())pkg/server/server.gotmp→/recoveredbefore cleanup)build/egress/entrypoint.shNodeIdto the:8080/health endpointpkg/server/server.goDeliberately excluded: livekit#1247 (graceful CPU drain)
The original bundle plan included livekit#1247 (graceful drain on high CPU). Dropped because
mainalready implements it natively —checkCPUKillstages a graceful EOS drain viaStopProcess/lowCPUResetDuration(seepkg/stats/monitor.go). Re-adding livekit#1247 would duplicate and conflict with upstream's own drain. No functionality lost.Adding
NodeIdchanges the shape of the:8080/health JSON. Any egress autoscaler that counts non-CpuLoadkeys as active egresses will miscountNodeIdas a phantom egress unless it excludes it by name (this exact issue blocked VR scale-down under SRE-4121; the Talview autoscaler already excludes bothCpuLoadandNodeId).Verification
All three applied cleanly onto
main;pkg/servercompiles clean;entrypoint.shis shell. Fullgo testneeds gstreamer/cgo (CI/Docker only).