docs(skill): clarify sudo keyring key is per-host, not always master#8
Merged
Conversation
The "sudo with auto-filled password" section implied the sudo password always lives under the `master` keyring key, so an agent reading the skill would assume every host uses `master` and fail on hosts whose secret is stored elsewhere. Document the real resolution order (-pk / SSH_SUDO_KEY / per-host password_key from settings.json / master fallback), state explicitly that named hosts auto-resolve their own key, and tell the agent to pass -pk= for ad-hoc IPs and verify with --host-list / --password-check. Reinforce the same point in the agent checklist. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
skills/sshx/SKILL.md, the sudo with auto-filled password section implied the sudo password always lives under themasterkeyring key (with an example commented# Uses keyring entry "master"). An agent reading this concludes every host's sudo password is undermaster, and then fails on any host whose secret is stored under a different key.Reality (verified in code)
The sudo keyring key is resolved per invocation:
-pk=/--password-key=(highest) —config.goSSH_SUDO_KEYenv var —config.gopassword_keyfromsettings.json, applied automatically when addressing the host by name —app.go:300master— last-resort fallback only —sshclient/client.go:26So
masteris not universal; named hosts auto-use their own key.Fix (docs only)
master; named hosts auto-resolve their key, pass-pk=<key>for ad-hoc IPs, and verify with--host-list/--password-check.### Documentationnote.No code changes.