Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
This PR replaces direct calls to https://httpbin.org in tests/real_world.rs with a helper that reads HTTPBIN_URL, and wires CI to run a local go-httpbin instance instead, reducing flakiness from the public service. Local developer runs remain unchanged (falling back to httpbin.org).
Changes:
- Add
httpbin(path)helper intests/real_world.rsand update all httpbin-backed tests/comments to use it. - New composite action
.github/actions/start-httpbinthat installs Go, runsgo-httpbinon127.0.0.1:8080, waits for readiness, and exportsHTTPBIN_URL; wired into the CItest(stable/full-checks) andcoveragejobs with failure-log dumping. Also factorsshould-run-full-checksinto a reusable step output and enablesset -euo pipefail/RUST_BACKTRACE=1. - Add Go module under
.github/ci-tools/pinninggo-httpbinv2.23.0 (with Dependabotgomodtracking) and a CHANGELOG entry.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/real_world.rs |
Introduce httpbin() helper; route httpbin tests through HTTPBIN_URL; update doc/log strings. |
.github/workflows/ci.yml |
Add should-run-full-checks output, start go-httpbin and dump log on failure in test & coverage jobs, set pipefail and RUST_BACKTRACE. |
.github/actions/start-httpbin/action.yml |
New composite action: install Go, build/start go-httpbin, wait for readiness, export HTTPBIN_URL. |
.github/ci-tools/go.mod |
New Go module pinning go-httpbin/v2 v2.23.0 via tool directive. |
.github/ci-tools/go.sum |
Checksums for the pinned go-httpbin module. |
.github/dependabot.yml |
Track the new gomod directory monthly. |
CHANGELOG.md |
Add Unreleased "Changed" entry describing the CI swap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…esn't affect local testing)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.