Skip to content

Add DroQ - #342

Draft
asmith26 wants to merge 2 commits into
takuseno:masterfrom
asmith26:droq
Draft

Add DroQ#342
asmith26 wants to merge 2 commits into
takuseno:masterfrom
asmith26:droq

Conversation

@asmith26

Copy link
Copy Markdown
Contributor

Attempt at #340 (WIP)

@asmith26
asmith26 marked this pull request as draft September 30, 2023 11:01
@asmith26 asmith26 changed the title Add Droq Add DroQ Sep 30, 2023
@codecov

codecov Bot commented Sep 30, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.49%. Comparing base (43e6769) to head (3099def).
⚠️ Report is 207 commits behind head on master.

Files with missing lines Patch % Lines
d3rlpy/algos/qlearning/droq.py 73.46% 13 Missing ⚠️
d3rlpy/algos/qlearning/torch/droq_impl.py 58.33% 5 Missing ⚠️
d3rlpy/models/torch/encoders.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
- Coverage   92.69%   92.49%   -0.20%     
==========================================
  Files         109      111       +2     
  Lines        7141     7208      +67     
==========================================
+ Hits         6619     6667      +48     
- Misses        522      541      +19     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@takuseno

takuseno commented Oct 1, 2023

Copy link
Copy Markdown
Owner

@asmith26 Thank you for the PR! The overall approach looks good to me. Let me know when this PR is ready for review.

@takuseno
takuseno self-requested a review October 1, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants