fix: re-enable LockmanResult tests with updated API compatibility - #232
Merged
Conversation
## Summary - Re-enabled LockmanResultTests.swift by updating for new LockmanResult API - Fixed all test methods to work with unlockToken parameters - Removed .disabled extension from test file ## Changes Made ### API Compatibility Updates - Updated all LockmanResult case usage to include unlockToken parameters: - .success(unlockToken: token) - .successWithPrecedingCancellation(unlockToken: token, error: error) - .cancel(error) remains unchanged - Replaced mock strategy with TestSingleExecutionStrategy from TestSupport - Fixed TestLockmanInfo constructor calls with proper parameter order ### Test Coverage Maintained - All 13 comprehensive test methods updated and working - Phase 1: Basic enum case testing with unlockToken - Phase 2: Sendable conformance and concurrent access testing - Phase 3: Error protocol integration testing - Phase 4: unlockToken functionality and type safety testing ### Technical Fixes - Removed fileprivate property access (LockmanUnlock.info) - Fixed strategy ID references to use TestSingleExecutionStrategy - Updated all TestLockmanInfo instantiations with correct parameters - Ensured all pattern matching works with new API structure ## Test Results - ✅ All 13 tests pass (Executed 13 tests, with 0 failures) - ✅ Complete API compatibility with unlockToken integration - ✅ Comprehensive coverage of LockmanResult enum functionality 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-enabled LockmanResultTests.swift by updating all test methods to work with the new LockmanResult API that includes unlockToken parameters.
Problem
The LockmanResultTests.swift file was disabled (
.disabledextension) because it was incompatible with the new LockmanResult API introduced in the major refactoring. The new API requires unlockToken parameters for success cases.Solution
Changes
LockmanResult API Updates
Test Coverage Maintained
Test Results
Type of Change
🤖 Generated with Claude Code