chore: upgrade Ladle to Vite 8 - #635
Merged
Merged
Conversation
|
Would it be feasible/desirable to include removing vite-tsconfig-paths in favor of |
LucaCorcella
approved these changes
Jun 24, 2026
tajo
approved these changes
Jun 28, 2026
tajo
left a comment
tajo
left a comment
Owner
There was a problem hiding this comment.
Verified locally: typecheck, lint, build, and the full e2e suite (including iframe/MDX paths) all pass on Node 23. Vite 8 upgrade looks solid. Approving and merging.
tajo
added a commit
that referenced
this pull request
Jun 28, 2026
…m) (#636) Address two follow-ups from the Vite 8 upgrade (#635): - Replace the vite-tsconfig-paths plugin with Vite 8's native resolve.tsconfigPaths option and drop the dependency. Still skipped under Yarn PnP or when the user supplies their own plugin. - Migrate the MDX plugin off the deprecated transformWithEsbuild to transformWithOxc. The dev (babel) path pins the classic JSX runtime to keep the emitted output byte-identical to the previous esbuild default. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@ladle/reactVerification
pnpm typecheckpnpm lintpnpm buildpnpm test