Skip to content

I-frame and random-sampling modes are not implemented #17

Description

@BlohoJo

"At inference time, SparkVSR supports flexible keyframe selection (manual specification, codec I-frame extraction, or random sampling) and a reference-free guidance mechanism that continuously balances keyframe adherence and blind restoration, ensuring robust performance even when reference keyframes are absent or imperfect."

I'm not seeing that.

It appears that only "manual" works.

If --ref_indices is left out, then it works in a very simple "automatic" kind of mode, returning only the first, middle, and last frame of the clip. (The _select_indices function in finetune/utils/ref_utils.py literally returns [0, total_frames // 2, total_frames - 1].)

Any idea as to when the much better I-frame and random sampling modes will be implemented?

Or is that never going to happen?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions