Skip to content

Add hub load progress info logs #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hession wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add hub load progress info logs #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions cmd/protoc-gen-cpp-tableau-loader/embed/templates/hub.pc.cc.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ std::shared_ptr<MessagerMap> Hub::InternalLoad(const std::filesystem::path& dir,
options = options ? options : std::make_shared<load::Options>();
for (auto iter : *msger_map) {
auto&& name = iter.first;
ATOM_DEBUG("loading %s", name.c_str());
ATOM_INFO("loading %s", name.c_str());
auto mopts = options->ParseMessagerOptionsByName(name);
bool ok = iter.second->Load(dir, fmt, mopts);
if (!ok) {
Expand All @@ -77,7 +77,7 @@ std::shared_ptr<MessagerMap> Hub::InternalLoad(const std::filesystem::path& dir,
#endif
return nullptr;
}
ATOM_DEBUG("loaded %s", name.c_str());
ATOM_INFO("loaded %s", name.c_str());
}

// restore to old protobuf log handler
Expand Down Expand Up @@ -126,11 +126,13 @@ bool Hub::Postprocess(std::shared_ptr<MessagerMap> msger_map) {
// messager-level postprocess
for (auto iter : *msger_map) {
auto msger = iter.second;
ATOM_INFO("postprocessing %s", iter.first.c_str());
bool ok = msger->ProcessAfterLoadAll(tmp_hub);
if (!ok) {
SetErrMsg("hub call ProcessAfterLoadAll failed, messager: " + iter.first);
return false;
}
ATOM_INFO("postprocessed %s", iter.first.c_str());
}
return true;
}
Expand Down
6 changes: 4 additions & 2 deletions test/cpp-tableau-loader/src/protoconf/hub.pc.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ std::shared_ptr<MessagerMap> Hub::InternalLoad(const std::filesystem::path& dir,
options = options ? options : std::make_shared<load::Options>();
for (auto iter : *msger_map) {
auto&& name = iter.first;
ATOM_DEBUG("loading %s", name.c_str());
ATOM_INFO("loading %s", name.c_str());
auto mopts = options->ParseMessagerOptionsByName(name);
bool ok = iter.second->Load(dir, fmt, mopts);
if (!ok) {
Expand All @@ -81,7 +81,7 @@ std::shared_ptr<MessagerMap> Hub::InternalLoad(const std::filesystem::path& dir,
#endif
return nullptr;
}
ATOM_DEBUG("loaded %s", name.c_str());
ATOM_INFO("loaded %s", name.c_str());
}

// restore to old protobuf log handler
Expand Down Expand Up @@ -130,11 +130,13 @@ bool Hub::Postprocess(std::shared_ptr<MessagerMap> msger_map) {
// messager-level postprocess
for (auto iter : *msger_map) {
auto msger = iter.second;
ATOM_INFO("postprocessing %s", iter.first.c_str());
bool ok = msger->ProcessAfterLoadAll(tmp_hub);
if (!ok) {
SetErrMsg("hub call ProcessAfterLoadAll failed, messager: " + iter.first);
return false;
}
ATOM_INFO("postprocessed %s", iter.first.c_str());
}
return true;
}
Expand Down
Loading