Feature/time picker - #41
Open
TxMk2 wants to merge 18 commits into
Open
Conversation
|
Visit the preview URL for this PR (updated for commit db31777): https://tabi-share-8ef6b--pr41-feature-time-picker-4v02zcn5.web.app (expires Mon, 06 Apr 2026 16:52:27 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 9f2a87ede127df7673322845e34cf22c1372d720 |
TxMk2
force-pushed
the
feature/time-picker
branch
from
February 22, 2026 07:05
77c56b3 to
c20b399
Compare
Open
TxMk2
marked this pull request as ready for review
February 22, 2026 07:32
Contributor
Author
|
@kuu13580 |
Contributor
|
@TxMk2
|
Contributor
Author
まじや、かなり反応が悪い。。。。 |
Contributor
Author
|
@kuu13580 |
kuu13580
reviewed
Mar 27, 2026
| const CLOCK_CENTER = CLOCK_SIZE / 2; | ||
| const NUMBER_RADIUS = CLOCK_SIZE / 2 - 20; | ||
|
|
||
| function ClockTimePicker() { |
Contributor
There was a problem hiding this comment.
@TxMk2
実装あざます！動いた
けど、このコンポーネント外部となんのやり取りもしてないから値を取れない...
通常のinput要素と同様のinterfaceを継承して値をonChange(内部実装で隠蔽)で受け取れるようにしてくれい
type ClockTimePickerProps = Omit<React.ComponentProps<'input'>, 'type'>;
function ClockTimePicker({ value, onChange, ...props }: ClockTimePickerProps)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
詳細
動作確認
time picker
clock time picker
確認項目