Allow different vendor - #170
Open
MegEdnazednav wants to merge 2 commits into
Open
Conversation
t-jindai
requested changes
May 27, 2021
t-jindai
left a comment
t-jindai
left a comment
Owner
There was a problem hiding this comment.
Thank you for your contribution !
Could you check my feedback ?
|
|
||
| name | default value | note | ||
| ------------ | ------------- | ------------- | ||
| ------------ | ------------- | ------------- |
Owner
There was a problem hiding this comment.
Can you add description about the new option here?
| const config = utils.getRelativeFile(options.gaConfigPath, options.cwd) | ||
| const $script = $('<script async custom-element="amp-analytics" src="https://cdn.ampproject.org/v0/amp-analytics-0.1.js" />') | ||
| const $config = $(`<amp-analytics type="googleanalytics"/><script type="application/json">${config}</script></amp-analytics>`) | ||
| const $config = $(`<amp-analytics type=${options.vendor}><script type="application/json">${config}</script></amp-analytics>`) |
Owner
There was a problem hiding this comment.
IMO, vender option might be ambiguous. 🤔 User may think what kind of vender it is.
How about analyticsVendor ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This change goes together with the PR made in https://github.com/tomoyukikashiro/gatsby-plugin-html2amp/pull/73