docs(agents): introduce ARCHITECTURE.md + lessons + bash/powershell rules; misc lint and CI fixes - #256
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a more structured “agent harness” documentation set (architecture + lessons learned + per-language style rules), introduces a /second-opinion Claude skill backed by GitHub Copilot CLI, and makes several lint/CI reliability tweaks (Makefile lint macro, ShellCheck config centralization, uv update behavior, and a workflow runner change).
Changes:
- Introduces new docs:
ARCHITECTURE.md(repo layout/recipes) anddesign/lessons.md(incident → rule postmortems), and refactorsAGENTS.mdinto an index. - Adds
.clauderules and a/second-opinionskill with parsing/brief tooling (review_brief.py,REVIEW-BRIEF.md). - Updates lint/CI plumbing:
PREK_RUNMakefile macro, moves ShellCheck excludes to.shellcheckrc, swaps ShellCheck pre-commit repo, tweaks uv self-update invocation, and changes the GitHub Actions runner label.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| Makefile | Adds PREK_RUN macro to preserve staged paths while running prek and reuses it across lint targets. |
| design/lessons.md | New postmortem-style lessons doc with commit references and durable rules. |
| ARCHITECTURE.md | New repo architecture and extension “recipes” documentation. |
| AGENTS.md | Slims to a compound-knowledge index pointing to the new docs and style rules. |
| .shellcheckrc | Centralizes global ShellCheck disables for consistent CLI/IDE/pre-commit behavior. |
| .pre-commit-config.yaml | Switches ShellCheck hook to the shellcheck-py mirror and relies on .shellcheckrc for excludes. |
| .gitignore | Ignores local Claude/OpenWolf-related files and settings. |
| .github/workflows/repo_checks.yml | Changes CI runner label for pre-commit checks workflow. |
| .claude/skills/second-opinion/SKILL.md | Adds skill definition + workflow for invoking GitHub Copilot CLI review and parsing results. |
| .claude/skills/second-opinion/scripts/review_brief.py | Adds tooling to check/discover/parse the second-opinion review brief. |
| .claude/skills/second-opinion/REVIEW-BRIEF.md | Adds repo-targeted review brief and output format for heterogeneous-model review. |
| .claude/rules/powershell-style.md | Adds PowerShell formatting/naming/error-handling conventions for agent auto-loading. |
| .claude/rules/bash-style.md | Adds Bash portability/style conventions for agent auto-loading. |
| .assets/provision/install_uv.sh | Adjusts uv self update to use env vars instead of the removed/brittle --system-certs flag. |
szymonos
force-pushed
the
chore/agents-harness
branch
from
June 14, 2026 13:26
f9e7272 to
3522a40
Compare
…ck config to .shellcheckrc
…CTURE.md, design/lessons.md, bash/powershell style rules, second-opinion skill
szymonos
force-pushed
the
chore/agents-harness
branch
from
June 14, 2026 13:36
3522a40 to
4b99da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENTS.mdslimmed to a compound-knowledge index pointing at new files:ARCHITECTURE.md(host/guest split, distro detection, hook inventory, test layout, recipes),design/lessons.md(4 postmortems mined fromfix(*)commits — POSIX guard, SSH probe, safe.directory, BSD regex),.claude/rules/bash-style.mdand.claude/rules/powershell-style.md(auto-load on matching globs). Adds the per-repo/second-opinionskill with alinux-setup-scripts-targetedREVIEW-BRIEF.md.fix(sh):install_uv— switch from the brittle--system-certsflag toUV_SYSTEM_CERTS=true UV_NATIVE_TLS=trueenv vars onuv self update; also quote"$HOME/.local/bin/uv".chore(ci):repo_checks— runner fromubuntu-latesttoubuntu-slim.chore(lint): PREK_RUN macro — centralizes the stage-all → prek → restore-paths flow shared bymake lint/lint-diff/lint-all, so auto-fixes land in the working tree without losing the prior staging (path-level; partially-staged hunks become fully staged). Extracts global shellcheck excludes (SC1090/SC2139/SC2148/SC2155/SC2174) into.shellcheckrcso VS Code, CLI, and pre-commit all see the same config; bumps the pre-commit hook to theshellcheck-pymirror.Test plan
make lint-diff— all 13 pre-commit hooks green on the consolidated commits/second-opinion(gpt-5.3-codex) reviewed the WIP — 1 confirmed bug (broken.claude/CLAUDE.mdsymlink target) fixed before consolidation, 1 warning dismissed as pre-existing.shellcheckrcrationale inlined,install_uvpath quoted, Makefile comment scoped to "paths"), 4 dismissed (mktemp false positive, ubuntu-slim valid in env, partial-staging pre-existing).claude/CLAUDE.mdresolves to rootAGENTS.md(cat .claude/CLAUDE.mdshould show the AGENTS.md content)ARCHITECTURE.md§ 5 recipes — are they accurate descriptions of how to extend this repo?design/lessons.mdentries — each maps to a real commit and a real durable rule🤖 Generated with Claude Code