Backport envy-nx through v1.5.0: aliases_git regex fix#251
Merged
Conversation
git_resolve_branch's case arms used `(|el|elop|elopment)` empty-alternative patterns. BSD grep on macOS silently fails to match the empty alternative, so `git_resolve_branch ""` and `git_resolve_branch "d"` returned the literal regex pattern instead of resolving to dev/devel/development. Same anti-pattern was lurking in the gbda alias. Replace with `(el|elop|elopment)?` which is unambiguously correct on both GNU and BSD grep. Linux works either way; this aligns the script with the portable form so shell config stays correct on any platform that ends up sourcing it. Ported from szymonos/envy-nx@9da3941. Caught upstream by their integration workflow's full bats suite running on macos-15.
Last ported through advances from c859bba (v1.4.0 / 2026-05-01) to 8e23552 (v1.5.0 / 2026-05-02). The 15 commits between were evaluated per the BACKPORT.md procedure: - 1 ported: aliases_git BSD grep regex fix (preceding commit) - 1 already in this repo: Invoke-GhRepoClone ssh-probe Get-Command guard (landed via #247) - 13 skipped: nx CLI feature work (doctor evolution, manifest-driven generation, Block C/D), release tooling (make release flow), docs site updates (docs/decisions.md, ARCHITECTURE.md), macOS-specific CI (bash 3.2 pin), and the MITM-probe cert/network discriminator which lives in the nix phase library that doesn't exist here.
szymonos
force-pushed
the
chore/port-envy-nx-1.5.0
branch
4 times, most recently
from
May 3, 2026 14:01
c3b15fc to
5156881
Compare
Onboard ps-modules to the repo
- add do-common/psm-windows imports to scripts that call functions relocated from utils-setup/utils-install during the modules refactor - replace runtime clone of szymonos/ps-modules + module_manage.ps1 with cp from ./modules/ in wsl_setup.ps1, linux_setup.sh, and Vagrantfiles - fix scripts_egsave.ps1 wrong fallback (Invoke-ExampleScriptSave is in do-common, not utils-setup) - correct stale module references in Pester test header comments Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
szymonos
force-pushed
the
chore/port-envy-nx-1.5.0
branch
from
May 3, 2026 14:10
5156881 to
8d2600e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the BACKPORT.md procedure, surveyed the 15 commits between envy-nx `v1.4.0` (last sync) and `v1.5.0` (`8e23552`, released 2026-05-02). One portable bug fix found:
`fix(sh): aliases_git BSD grep regex empty-alternative incompatibility` (78b177d)
`git_resolve_branch`'s case arms used `(|el|elop|elopment)` empty-alternative patterns. BSD grep on macOS silently fails to match the empty alternative, so `git_resolve_branch ""` and `git_resolve_branch "d"` returned the literal regex pattern instead of resolving to `dev`/`devel`/`development`. Same anti-pattern was lurking in the `gbda` alias.
Replaced with `(el|elop|elopment)?` — unambiguously correct on both GNU and BSD grep. This repo targets Linux only, but having portable shell config means the file stays correct anywhere it ends up sourced.
Caught upstream by envy-nx's integration workflow's full bats suite running on `macos-15`. Ports envy-nx@9da3941.
Skipped (with rationale)
Test plan
🤖 Generated with Claude Code