feat(sh): install_humioctl - #242
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds humioctl to the existing Kubernetes “dev tools” installation scope so that both WSL-based and native Linux setup flows install the Humio CLI alongside the other k8s developer utilities.
Changes:
- Add a new provisioner script to install
humioctlfrom GitHub releases. - Wire
humioctlinstallation into thek8s_devscope for Linux setup and WSL setup. - Update WSL scope documentation text to include
humioctl.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
wsl/wsl_setup.ps1 |
Adds humioctl to the k8s_dev WSL provisioning sequence and updates scope help text. |
wsl/wsl_install.ps1 |
Updates scope help text to include humioctl in k8s_dev. |
.assets/scripts/linux_setup.sh |
Installs humioctl when the k8s_dev scope is selected on Linux. |
.assets/provision/install_humioctl.sh |
New installer script that downloads and installs the humioctl binary from GitHub releases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.assets/provision/install_humioctl.shto install humio/cli (humioctl) from upstream GitHub releases, idempotent on re-run.humioctlin.assets/scripts/linux_setup.sh(Linux host entry point) and in the WSL orchestration scriptswsl/wsl_install.ps1/wsl/wsl_setup.ps1so it can be selected like any other tool.Test plan
make lint-diff- all applicable pre-commit hooks green (shellcheck, shfmt, bats)sudo .assets/provision/install_humioctl.shinstalls the latest release; re-running printshumioctl vX.Y.Z is already latestand exits 0humioctl --versionreports the installed version🤖 Generated with Claude Code