run: exchange manual mock of linecache.checkcache for unittest.mock.patch - #4429
Draft
behrmann wants to merge 1 commit into
Draft
run: exchange manual mock of linecache.checkcache for unittest.mock.patch#4429behrmann wants to merge 1 commit into
behrmann wants to merge 1 commit into
Conversation
…atch
The last remaining error ty is showing is
Object of type `(filename=None) -> None` is not assignable to attribute `checkcache` of type `def checkcache(filename: str | None = None) -> None`
which is a problem with ty's handling of shadowing being more conservative than
other typecheckers.
Since what we want to do here is basically a mock, patching
linecache.checkcache to a function that won't evict out cache entries, let's
use a proper mock instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the successor to #4168 from which all things but one have been fixed.
The last remaining error ty is showing is
which is a problem with ty's handling of shadowing being more conservative than other typecheckers.
Since what we want to do here is basically a mock, patching linecache.checkcache to a function that won't evict out cache entries, let's use a proper mock instead.