Skip to content

Bundle manifest - #3997

Open
jcgl17 wants to merge 2 commits into
systemd:mainfrom
jcgl17:bundle-manifest
Open

Bundle manifest#3997
jcgl17 wants to merge 2 commits into
systemd:mainfrom
jcgl17:bundle-manifest

Conversation

@jcgl17

@jcgl17 jcgl17 commented Nov 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

My attempt to close #3995. Writes the json manifest to /usr/lib/os-manifest. Maybe it's too presumptuous to claim that path, but naming is hard and I had to pick something.

Since the manifest takes up only ~300k with >2000 packages, compressing the manifest didn't seem to make sense.

@jcgl17

jcgl17 commented Nov 15, 2025

Copy link
Copy Markdown
Contributor Author

It's probably better to name this file something like mkosi-manifest instead of os-manifest. A more reasonable claim.

@behrmann

behrmann commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

It's probably better to name this file something like mkosi-manifest instead of os-manifest. A more reasonable claim.

I'd prefer this to be mkosi-named, otherwise the name is too generic and similar to os-release and for something more general a UAPI spec would be more fitting that should then also take all the existing SBOM stuff into consideration, let's keep this localised to mkosi.

@jcgl17
jcgl17 force-pushed the bundle-manifest branch 2 times, most recently from 07aa7c2 to 8ab8d95 Compare November 17, 2025 15:09
@jcgl17

jcgl17 commented Nov 17, 2025

Copy link
Copy Markdown
Contributor Author

Sounds right to me. Just pushed a change to change from os-manifest to mkosi-manifest.

jcgl17 added a commit to jcgl17/particleos that referenced this pull request Nov 26, 2025
@jcgl17
To-upstream: Symlink in /etc/mkosi-manifest
1c7daab 
Will upstream after/if this is merged:
systemd/mkosi#3997
daandemeyer
daandemeyer requested changes Dec 17, 2025
View reviewed changes

@daandemeyer daandemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should come up with a design that allows us to store manifests in sysexts and other images as well.

Please store the image manifest in /usr/lib/mkosi/.manifest and store extension manifests in /usr/lib/mkosi/extension-manifest.d/.manifest

jcgl17 added a commit to jcgl17/particleos that referenced this pull request Jun 13, 2026
@jcgl17
To-upstream: Symlink in /etc/mkosi-manifest
8d58704 
Will upstream after/if this is merged:
systemd/mkosi#3997
@jcgl17
Write manifest as soon as packages have been recorded
c0be0d0
@jcgl17
Optionally save json manifest to /usr/lib/mkosi-manifest
742d029 
If json manifest is requested and metadata would not be cleaned due to
CleanPackageMetadata=, write the manifest to the OS image under the same
condition as when os-release would be written (i.e. not sysext, confext,
addon, or overlay).
@jcgl17

jcgl17 commented Sep 6, 2026

Copy link
Copy Markdown
Contributor Author

@daandemeyer, sorry for taking so long to come back around to this! I've pushed changes that I believe should implement the behavior you outlined, namely basing the name manifest path on the output format:

  1. If an extension image (per OutputFormat.is_extension_image()), then save to /usr/lib/mkosi/extension-manifest.d/.manifest
  2. Otherwise, save to /usr/lib/mkosi/.manifest

How does this look to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daandemeyer daandemeyer daandemeyer requested changes

Assignees

No one assigned

Labels

reviewed/needs-rework

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optionally include manifest in built image

3 participants

@jcgl17 @behrmann @daandemeyer