wifi: vwifi: prevent NULL pointer dereference of vif->ap in virtio mode#94
Open
ga13234624 wants to merge 1 commit into
Open
wifi: vwifi: prevent NULL pointer dereference of vif->ap in virtio mode#94ga13234624 wants to merge 1 commit into
ga13234624 wants to merge 1 commit into
Conversation
The bss_param configuration reads BSS parameters (beacon interval, DTIM, short preamble) from the local AP object via vif->ap. While vif->ap is valid in non-virtio mode where the AP is another local vwifi_vif, it is legitimately NULL in virtio mode because the AP resides in a different VM. Attempting to access it blindly leads to a NULL pointer dereference. Fix this by checking if vif->ap is NULL and skipping the bss_param setup accordingly when operating in virtio mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bss_param configuration reads BSS parameters (beacon interval, DTIM, short preamble) from the local AP object via vif->ap.
While vif->ap is valid in non-virtio mode where the AP is another local vwifi_vif, it is legitimately NULL in virtio mode because the AP resides in a different VM. Attempting to access it blindly leads to a NULL pointer dereference.
Fix this by checking if vif->ap is NULL and skipping the bss_param setup accordingly when operating in virtio mode.