vwifi: zero-initialize station_info in connect paths#93
Open
ga13234624 wants to merge 1 commit into
Open
Conversation
Both vwifi_virtio_mgmt_rx_connect_request() and vwifi_connect_routine() allocated struct station_info with kmalloc(), leaving the ->filled bitmap and other members uninitialized. cfg80211 inspects ->filled to decide which fields are valid, so passing garbage there causes it to read uninitialized members, leading to a kernel panic. Use kzalloc() in both call sites to ensure all fields start zeroed. The explicitly assigned assoc_req_ies/assoc_req_ies_len are unaffected, as they are read unconditionally rather than gated by ->filled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both vwifi_virtio_mgmt_rx_connect_request() and vwifi_connect_routine() allocated struct station_info with kmalloc(), leaving the ->filled bitmap and other members uninitialized. cfg80211 inspects ->filled to decide which fields are valid, so passing garbage there causes it to read uninitialized members, leading to a kernel panic.
Use kzalloc() in both call sites to ensure all fields start zeroed. The explicitly assigned assoc_req_ies/assoc_req_ies_len are unaffected, as they are read unconditionally rather than gated by ->filled.