Allow custom extension ID for Intercode issuing (e.g. +FRII1) - #17
Merged
Conversation
The encoder previously hardcoded the extension ID as `_<RICS>II1`. This adds an optional `extensionId` field to `IntercodeIssuingDataInput` so callers can pass the string as-is (e.g. `+FRII1` for country-code variant) instead of always deriving it from a numeric RICS code. https://claude.ai/code/session_018mxZQ6pZkHoU8xHgxNkDKt
The decoder now stores the original extensionId string (e.g. "+FRII1") on IntercodeIssuingData so it survives the decode → input → encode cycle. Both decodedToInput (tests) and ticketToInput (website) now propagate the field to the encoder input. https://claude.ai/code/session_018mxZQ6pZkHoU8xHgxNkDKt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The encoder previously hardcoded the extension ID as
_<RICS>II1. This adds an optionalextensionIdfield toIntercodeIssuingDataInputso callers can pass the string as-is (e.g.+FRII1for country-code variant) instead of always deriving it from a numeric RICS code.https://claude.ai/code/session_018mxZQ6pZkHoU8xHgxNkDKt