Skip to content

Fix #141: Make URL field required in proposal creation form #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
osiastedian merged 1 commit into from
Oct 4, 2025
Merged

Fix #141: Make URL field required in proposal creation form #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/proposal/DescriptionProposal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import {Editor} from "react-draft-wysiwyg";
import "react-draft-wysiwyg/dist/react-draft-wysiwyg.css";

const schema = yup.object().shape({
proposalUrl: yup.string().url("Must be a valid url"),
proposalUrl: yup.string().url("Must be a valid url").required("URL is required"),
});


Expand Down Expand Up @@ -185,6 +185,7 @@ function DescriptionProposal({onNext, onBack}) {
name="proposalUrl"
id="proposalUrl"
ref={register}
required
/>
<ErrorMessage
errors={errors}
Expand Down
2 changes: 1 addition & 1 deletion src/components/proposal/ProposalForm.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ function ProposalForm() {
title,
name,
description,
url: url || 'emptyField',
url,
firstEpoch: payment.proposalStartEpoch,
startEpoch: payment.proposalStartEpoch,
endEpoch: payment.proposalEndEpoch,
Expand Down