Skip to content

chore: add disclaimer on go_submit#138

Merged
osiastedian merged 1 commit into
syscoin:masterfrom
osiastedian:go-submit-disclaimer
Sep 5, 2025
Merged

chore: add disclaimer on go_submit#138
osiastedian merged 1 commit into
syscoin:masterfrom
osiastedian:go-submit-disclaimer

Conversation

@osiastedian

@osiastedian osiastedian commented Sep 5, 2025

Copy link
Copy Markdown
Contributor

Addresses #120
Screenshot 2025-09-06 at 7 21 14 AM

@github-actions

github-actions Bot commented Sep 5, 2025

Copy link
Copy Markdown

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Improve disclaimer clarity

The disclaimer should specify what happens if go_submit is run too early. Instead
of just saying it "may cause your proposal to fail," explain the consequences more
clearly (e.g., funds loss, transaction reversal). Consider adding a link to
relevant documentation for further details.

src/components/proposal/ProposalForm.jsx [485-488]

 {/* Disclaimer about waiting before go_submit */}
 <div className="alert alert-warning mb-3 py-2 px-3" role="alert">
-  <strong>Important:</strong> Please wait at least <b>5 minutes</b> or <b>1 block confirmation</b> after sending the payment transaction before running <code>go_submit</code>. Submitting too early may cause your proposal to fail.
+  <strong>Important:</strong> Please wait at least <b>5 minutes</b> or <b>1 block confirmation</b> after sending the payment transaction before running <code>go_submit</code>. Submitting too early may result in the loss of your funds and transaction reversal.  For more information, see <a href="/help/go_submit">our help documentation</a>.
 </div>
Suggestion importance[1-10]: 7

__

Why: The suggestion improves the clarity and helpfulness of the disclaimer by specifying the consequences of prematurely running go_submit and adding a link to relevant documentation. This is a valuable improvement, but not critical.

Medium

@osiastedian
osiastedian merged commit 271348b into syscoin:master Sep 5, 2025
2 checks passed
@osiastedian
osiastedian deleted the go-submit-disclaimer branch September 5, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant